-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21698] Add -v or --version to cli command tool #5401
Open
depink5
wants to merge
6
commits into
master
Choose a base branch
from
feature/add_version_to_cli_command_tool
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denisa <denisa@eprosima.com>
Signed-off-by: Denisa <denisa@eprosima.com>
depink5
requested review from
Carlosespicur
and removed request for
Carlosespicur
November 15, 2024 09:33
cferreiragonz
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far! Just a few suggestions:
- I would add one test to check this behavior to
test/system/tools/fastdds/tests.py
. In this way we can test it works in other platforms and that future commits don't break the new feature. - I would change the indentation in the
package.xml
file to avoid printing the description with indentation. Also we can changeeprosima
toeProsima
. - Finally, we could try to parse the description to use shorter sentences. This will improve readability in small terminals. This is just an aesthetic suggestion though.
Signed-off-by: Denisa <denisa@eprosima.com>
MiguelCompany
requested changes
Nov 20, 2024
Signed-off-by: Denisa <denisa@eprosima.com>
Signed-off-by: Denisa <denisa@eprosima.com>
cferreiragonz
requested changes
Nov 20, 2024
Signed-off-by: Denisa <denisa@eprosima.com>
cferreiragonz
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the cli command tool to provide the version of the installed Fast DDS. Modify CMakeLists.txt in fastdds repository to export 'package.xml' to install directory.
Description
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist