Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] viewsWelcome#enablement is not honored by Theia #14309

Closed
Tracked by #13051
dankeboy36 opened this issue Oct 14, 2024 · 3 comments · Fixed by #14391
Closed
Tracked by #13051

[vscode] viewsWelcome#enablement is not honored by Theia #14309

dankeboy36 opened this issue Oct 14, 2024 · 3 comments · Fixed by #14391
Labels
contribution-point issues related to vscode contribution point support vscode issues related to VSCode compatibility

Comments

@dankeboy36
Copy link
Contributor

Bug Description:

viewsWelcome#enablement can be used to control the enablement of the buttons and links, see for example: microsoft/vscode#114304.

This is working fine in Code but not in Theia. I am working on an extension for the Arduino IDE, and the Theia version is 1.41.0.

Code:

Screen Shot 2024-10-14 at 14 16 31

Theia/Arduino IDE:

Screen Shot 2024-10-14 at 14 16 44

The screenshot was taken with https://github.com/PaulStoffregen/secure_plugin_vscode/raw/af5c2b3907c21daf19fb152dcce335e46f926270/teensysecurity-0.0.1.vsix.

Relevant VS Code config: https://github.com/PaulStoffregen/secure_plugin_vscode/blob/af5c2b3907c21daf19fb152dcce335e46f926270/package.json#L65-L81

Steps to Reproduce:

  1. Create viewsWelcome for an always empty tree view
  2. Set enablement to false
  3. All buttons and links are enabled in the content. It should not. Only the Click link should be enabled.

Additional Information

  • Operating System:
  • Theia Version: 1.41.0
@tsmaeder tsmaeder added vscode issues related to VSCode compatibility contribution-point issues related to vscode contribution point support labels Oct 17, 2024
@rschnekenbu rschnekenbu mentioned this issue Oct 17, 2024
Open
17 tasks
dankeboy36 added a commit to dankeboy36/arduino-ide that referenced this issue Oct 26, 2024
@dankeboy36
fix: align viewsWelcome behavior to VS Code
7a8acdc 
Ref: eclipse-theia/theia#14309
Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
@dankeboy36 dankeboy36 mentioned this issue Oct 26, 2024
Open
4 tasks
@dankeboy36
Copy link
Contributor Author

I patched the Arduino IDE if anybody needs the fixes: arduino/arduino-ide#2543

@JonasHelming
Copy link
Contributor

@dankeboy36 Could you contribute the fix also to Theia? :-)

dankeboy36 added a commit to dankeboy36/theia that referenced this issue Nov 3, 2024
@dankeboy36
fix: align viewWelcome to VS Code
1e12b94 
Closes: eclipse-theia#14309
Ref: arduino/arduino-ide#2543
Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
@dankeboy36 dankeboy36 mentioned this issue Nov 3, 2024
Merged
1 task
@dankeboy36
Copy link
Contributor Author

PR: #14391

dankeboy36 added a commit to dankeboy36/arduino-ide that referenced this issue Nov 11, 2024
@dankeboy36
Merge branch 'main' into patch/eclipse-theia/theia#14309
aa941ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution-point issues related to vscode contribution point support vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: align viewWelcome to VS Code dankeboy36/theia
3 participants
@JonasHelming @tsmaeder @dankeboy36