Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align viewsWelcome behavior to VS Code #2543

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dankeboy36
Copy link
Contributor

@dankeboy36 dankeboy36 commented Oct 26, 2024

Motivation

This PR patches the default behavior of the viewsWelcome and aligns it to VS Code, most notably, it honors the enablement property of the viewsWelcome contribution (eclipse-theia/theia#14309) to provide dynamic UX via a VS Code when context.

Originally from the Arduino Forum:

I know it's just static info with links... but if could it could be dynamic, the ideal GUI would disable the 3 sketch buttons until the key is created.

viewsWelcome.mov

Change description

Other information

Ref: eclipse-theia/theia#14309

Package index for the 1.60 Teensy core: https://www.pjrc.com/teensy/td_160-beta3/package_teensy_0.60.3_index.json

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Ref: eclipse-theia/theia#14309
Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
@dankeboy36
Copy link
Contributor Author

The build failure is most likely unrelated to the proposed changes; the CI must not sign the builds from forks:

Custom windows signing was no performed one of the following variables was not provided: SIGNTOOL_PATH (C:/Program Files (x86)/Windows Kits/10/bin/10.0.19041.0/x86/signtool.exe), INSTALLER_CERT_WINDOWS_CERT (C:/Users/Utente/AppData/Local/Temp/cert.cer), CERT_PASSWORD (), CONTAINER_NAME ()

dankeboy36 added a commit to dankeboy36/theia that referenced this pull request Nov 3, 2024
Closes: eclipse-theia#14309
Ref: arduino/arduino-ide#2543
Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
rschnekenbu pushed a commit to eclipse-theia/theia that referenced this pull request Nov 7, 2024
Closes: #14309
Ref: arduino/arduino-ide#2543

Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant