fix(ci): pin Python 3.11 on the CI #13011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GH Actions comes with Python 3.12 by default if version 3.x specified. `distutils` has been removed from 3.12, which causes a build problem with `node-gyp`. This commit pins the Python version to 3.11 on the CI. Ref: nodejs/node-gyp#2869 Closes eclipse-theia#13008 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
tsmaeder
approved these changes
Oct 20, 2023
|
@kittaakos do you know if we need a follow-up related to distutils? |
|
@tsmaeder, I do not know. It's a Python lib: https://docs.python.org/3.11/library/distutils.html. Hopefully, there will be a fix in nodejs/node-gyp#2869. See #13008 (comment). |
1 task
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
GH Actions comes with Python 3.12 by default if version 3.x specified.
distutilshas been removed from 3.12, which causes a build problem withnode-gyp. This commit pins the Python version to 3.11 on the CI.Ref: nodejs/node-gyp#2869
Closes #13008
The credit goes to @per1234 for identifying the problem and fixing it downstream in the Arduino IDE.
How to test
The Windows CI must pass the
yarn installphase.Follow-ups
Preferably, there will be a fix in
node-gyp. Theia can pick it up, and the CI can continue to use 3.x instead of 3.11 for Python.Review checklist
Reminder for reviewers