fix selection and improve active text editor behaviour #14480
+27
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This fixes the selection property in the vscode api of
SimpleMonacoEditorswhen selecting text bottom to top and improves theactiveTextEditorbehaviour further to align it more to vscode.Specificly this improves the case when switching from a different file to an already open notebook editor and the currently selected cell is a code cell, then the cell is set at the
activeTextEditorFixes #14475
Fixes #14476
Fixes #14477
How to test
you can use this extension
Both with the
Notebook-Test: get current selectionor theNotebook-Test: get active text editorcommandFollow-ups
Review checklist
Reminder for reviewers