Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDF5 support for CUDA/HIP/SYCL variants #71

Merged
merged 9 commits into from
Feb 21, 2024
Merged

Conversation

MichaelSt98
Copy link
Contributor

HDF5 support for CUDA/HIP/SYCL variants, similar to PR #62 ...

CUDA and SYCL tested on AC with NVHPC 22.11

HIP tested on LUMI ... which gave me some problems, explaining why this is a draft PR ...

  • unable to find hdf5.h
  • able to find hdf5.h removing set(CMAKE_CXX_COMPILER "${ROCM_PATH}/bin/hipcc")
    • removing this allows still compilation for the device (at least for CCE 16.01)
    • however, different problems with CCE 15.01

tested a lot of different things, without any success in finding a solution that works for the different toolchains/cray-gpu versions

@MichaelSt98 MichaelSt98 marked this pull request as ready for review February 20, 2024 10:37
Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working also on AC. Many thanks!

Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only had time to eyeball this, but looks good to me overall - tests look good as well. GTG from me. :shipit:

@reuterbal reuterbal merged commit dcaeba1 into develop Feb 21, 2024
18 checks passed
@reuterbal reuterbal deleted the nams_low_level_gpu_hdf5 branch February 21, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants