Single-precision support for HIP variants #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuterbal
approved these changes
Jul 26, 2024
| @@ -10,17 +10,18 @@ | |||
|
|
|||
| #include "cloudsc_validate.h" | |||
|
|
|||
| #include <float.h> | |||
| #include <dtype.h> | |||
There was a problem hiding this comment.
#include "dtype.h" or redundant?
Was previously used for DBL_EPSILON, I think.
Comment on lines
63
to
64
| // #pragma omp parallel for default(shared) private(b, bsize, jk) \ | ||
| // reduction(min:zminval) reduction(max:zmaxval,zmaxerr) reduction(+:zerrsum,zsum) |
There was a problem hiding this comment.
I think you re-enabled this in the othe rPR?
Comment on lines
101
to
102
| // #pragma omp parallel for default(shared) private(b, bsize, jl, jk) \ | ||
| // reduction(min:zminval) reduction(max:zmaxval,zmaxerr) reduction(+:zerrsum,zsum) |
Comment on lines
91
to
92
| // dtype (*field)[nlev][nlon] = (dtype (*)[nlev][nlon]) v_field; | ||
| // dtype (*reference)[nlev][nlon] = (dtype (*)[nlev][nlon]) v_ref; |
Comment on lines
54
to
55
| //dtype (*field)[nlon] = (dtype (*)[nlon]) v_field; | ||
| //dtype (*reference)[nlon] = (dtype (*)[nlon]) v_ref; |
Comment on lines
133
to
134
| // dtype (*field)[nclv][nlev][nlon] = (dtype (*)[nclv][nlev][nlon]) v_field; | ||
| // dtype (*reference)[nclv][nlev][nlon] = (dtype (*)[nclv][nlev][nlon]) v_ref; |
Comment on lines
142
to
143
| // #pragma omp parallel for default(shared) private(b, bsize, jl, jk, jm) \ | ||
| // reduction(min:zminval) reduction(max:zmaxval,zmaxerr) reduction(+:zerrsum,zsum) |
MichaelSt98
force-pushed
the
nams-hip-sp-single-dir
branch
from
ce87db3
to
50863dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIP SP tested on LUMI via e.g.
./cloudsc-bundle build --clean --build-dir=build-sp-hip --arch=arch/eurohpc/lumi/cray-gpu/16.0.1 --with-hip --single-precision [--with-serialbox]