Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix criteria count & Pin lint versions #253

Merged
merged 3 commits into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/black.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

# install black
- name: install black
run: pip install black
run: pip install -c constraints.txt black

# run black
- name: run black
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/flake8.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

# install flake8
- name: install flake8
run: pip install flake8
run: pip install -c constraints.txt flake8

# run black
- name: run flake8
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/zpretty.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

# install zpretty
- name: install zpretty
run: pip install zpretty
run: pip install -c constraints.txt zpretty

# run zpretty
- name: run zpretty
Expand Down
3 changes: 3 additions & 0 deletions constraints.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
black == 23.9.1
flake8 == 4.0.1
zpretty == 3.1.0

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion eea/facetednavigation/browser/static/faceted-jquery.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion eea/facetednavigation/browser/static/faceted-view.min.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions eea/facetednavigation/widgets/criteria/view.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ Faceted.CriteriaWidget.prototype = {
});
});

var count = jQuery("dd span", context.area).length;
context.toggle_button_count.text("(" + count + ")");
var count_detail = jQuery("dd span.title", context.area).length;
context.toggle_button_count.text("(" + count_detail + ")");

if (!empty) {
context.widget.fadeIn("fast");
Expand Down
Loading