Skip to content

Commit

Permalink
chore: update GHA versions, tap (#285)
Browse files Browse the repository at this point in the history
* chore: update versions in workflows

* chore: test update to tap 18
  • Loading branch information
wkillerud authored Mar 1, 2024
1 parent 6bc8d59 commit 4426ebb
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 14 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20
- name: install dependencies
run: |
npm install
Expand Down Expand Up @@ -53,11 +53,11 @@ jobs:
needs: [test]
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20
- name: npm install
run: |
npm install
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
node-version: [14.x, 16.x]
node-version: [18, 20]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: install dependencies
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@ tmp/**/*
coverage
.vscode
eik.json
types
types
.tap/
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"eikjson.d.ts"
],
"scripts": {
"test": "tap --no-check-coverage",
"test": "tap --disable-coverage --allow-empty-coverage",
"lint:fix": "eslint --fix .",
"lint": "eslint .",
"schema:types": "json2ts lib/schemas/eikjson.schema.json > eikjson.d.ts",
Expand Down Expand Up @@ -58,7 +58,7 @@
"prettier": "2.8.8",
"semantic-release": "19.0.5",
"stoppable": "1.1.0",
"tap": "16.3.9",
"tap": "18.7.0",
"typescript": "4.9.5"
}
}
2 changes: 1 addition & 1 deletion test/helpers/config-store.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ test('invalid json error', (t) => {
try {
configStore.findInDirectory('/pizza dir', jsonReaderStub);
} catch (e) {
t.equal(e.message, 'Unexpected token o in JSON at position 1');
t.match(e.message, /Unexpected token/);
}
t.end();
});
Expand Down
2 changes: 1 addition & 1 deletion test/helpers/local-assets.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ test('Setup development routes for fastify', async (t) => {
});

test('Setup development routes for hapi', async (t) => {
const server = new Hapi.Server();
const server = Hapi.Server();
await localAssets(server, __dirname);
await server.start();
const address = server.info.uri;
Expand Down

0 comments on commit 4426ebb

Please sign in to comment.