useSniffing parameter handling was flipped (#445)

elastic · Sep 23, 2024 · ec6774c · ec6774c
1 parent 9ec7e0c
commit ec6774c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Elastic.Serilog.Sinks/ConfigSinkExtensions.cs b/src/Elastic.Serilog.Sinks/ConfigSinkExtensions.cs
@@ -28,7 +28,7 @@ public static LoggerConfiguration Elasticsearch(
 			this LoggerSinkConfiguration loggerConfiguration,
 			BootstrapMethod bootstrapMethod,
 			ICollection<Uri> nodes,
-			bool useSniffing = true,
+			bool useSniffing = false,
 			string? dataStream = null,
 			string? ilmPolicy = null,
 			string? apiKey = null,
@@ -58,7 +58,7 @@ public static LoggerConfiguration Elasticsearch(
 			LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum
 		)
 		{
-			var transportConfig = !useSniffing ? TransportHelper.Static(nodes) : TransportHelper.Sniffing(nodes);
+			var transportConfig = useSniffing ? TransportHelper.Sniffing(nodes) : TransportHelper.Static(nodes);
 			SetTransportConfig(transportConfig, apiKey, username, password, proxy, proxyUsername, proxyPassword, fingerprint, debugMode
 			);
 

diff --git a/src/Elastic.Serilog.Sinks/ElasticsearchSinkExtensions.cs b/src/Elastic.Serilog.Sinks/ElasticsearchSinkExtensions.cs
@@ -48,12 +48,12 @@ public static LoggerConfiguration Elasticsearch(
 			ICollection<Uri> nodes,
 			Action<ElasticsearchSinkOptions>? configureOptions = null,
 			Action<TransportConfiguration>? configureTransport = null,
-			bool useSniffing = true,
+			bool useSniffing = false,
 			LoggingLevelSwitch? levelSwitch = null,
 			LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum
 		)
 		{
-			var transportConfig = useSniffing ? TransportHelper.Static(nodes) : TransportHelper.Sniffing(nodes);
+			var transportConfig = useSniffing ? TransportHelper.Sniffing(nodes) : TransportHelper.Static(nodes) ;
 			configureTransport?.Invoke(transportConfig);
 
 			var sinkOptions = new ElasticsearchSinkOptions(new DistributedTransport(transportConfig));
@@ -73,12 +73,12 @@ public static LoggerConfiguration Elasticsearch<TEcsDocument>(
 			ICollection<Uri> nodes,
 			Action<ElasticsearchSinkOptions<TEcsDocument>>? configureOptions = null,
 			Action<TransportConfiguration>? configureTransport = null,
-			bool useSniffing = true,
+			bool useSniffing = false,
 			LoggingLevelSwitch? levelSwitch = null,
 			LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum
 		) where TEcsDocument : EcsDocument, new()
 		{
-			var transportConfig = useSniffing ? TransportHelper.Static(nodes) : TransportHelper.Sniffing(nodes);
+			var transportConfig = useSniffing ? TransportHelper.Sniffing(nodes) :  TransportHelper.Static(nodes);
 			configureTransport?.Invoke(transportConfig);
 			var sinkOptions = new ElasticsearchSinkOptions<TEcsDocument>(new DistributedTransport(transportConfig));
 			configureOptions?.Invoke(sinkOptions);