Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow importing reusable ECS fields at the root level when not allowed #1435

Closed
Tracked by #539
jsoriano opened this issue Sep 4, 2023 · 0 comments · Fixed by #1441
Closed
Tracked by #539

Disallow importing reusable ECS fields at the root level when not allowed #1435

jsoriano opened this issue Sep 4, 2023 · 0 comments · Fixed by #1441
Assignees
Labels
Team:Ecosystem Label for the Packages Ecosystem team

Comments

@jsoriano
Copy link
Member

jsoriano commented Sep 4, 2023

Elastic Package is currently allowing to import reusable ECS fields at the root level when they are not allowed. This happens for example with geo fields, that shouldn't be at the root level, but nested under some specific groups, see https://www.elastic.co/guide/en/ecs/8.9/ecs-geo.html#_field_reuse_10

Conditionally remove the logic for this, so packages using format version v3 or greater cannot import these fields this way. It should still be supported for older packages to avoid breaking changes.
Packages that need to use these fields at the root level will need to copy the resolved definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant