Disallow importing ECS fields root level #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
reviewed
Sep 12, 2023
💚 Build Succeeded
History
cc @jsoriano |
bhapas
pushed a commit
to bhapas/elastic-package
that referenced
this pull request
Sep 21, 2023
Elastic Package should not import reusable ECS fields that are defined at the top level, but are not intended to be reusable there. Fail in that case for packages starting on Package Spec v3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elastic Package should not import reusable ECS fields that are
defined at the top level, but are not intended to be reusable there.
Fail in that case for packages starting on Package Spec v3.
Test package requires a release of Package Spec v3.Package Spec v3 not needed for this test because field import fails before running validations.Closes #1435.