Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SystemTextJsonSerializer base class and relevant extensions methods #119

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

flobernd
Copy link
Member

Add SystemTextJsonSerializer base class and relevant extensions methods.

Closes #117

@flobernd flobernd added enhancement New feature or request v0.4.23 labels Oct 11, 2024
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a q? But LGTM!

It'd be nice if we can rid of Initialise and do the work eagerly.

@flobernd
Copy link
Member Author

Thank you for reviewing! I'll check the Initialize case tomorrow in the morning 🙂

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹 LGTM

@flobernd flobernd merged commit 7c87cd8 into main Oct 16, 2024
4 checks passed
@stevejgordon stevejgordon deleted the system-text-json-serializer branch November 8, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v0.4.23
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move SystemTextJsonSerializer base class to Elastic.Transport
2 participants