Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standalone agent config examples (System, AWS S3, other basic configs) #744

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Dec 6, 2023

As suggested in #65, we need some example configurations for standalone Elastic Agent. This adds to the ones we've already created for Nginx and Apache, via #588 and #584 respectively.

See the following preview pages for the new example configs:

NOTE:

  • The settings descriptions in the above match the Apache and Nginx examples.
  • This also fixes the "API key" docs link in the existing examples.

Closes: #690


Edit: I had removed the "configure multiple outputs for each input" example, but it's now fixed up and added back in.

@kilfoyle kilfoyle requested a review from a team as a code owner December 6, 2023 20:51
Copy link

github-actions bot commented Dec 6, 2023

A documentation preview will be available soon.
Help us out by validating the Buildkite preview and reporting issues here.

@kilfoyle kilfoyle changed the title Add System and S3 standalone agent config examples Add standalone agent config examples (System, AWS S3, other basics) Dec 6, 2023
@kilfoyle kilfoyle changed the title Add standalone agent config examples (System, AWS S3, other basics) Add standalone agent config examples (System, AWS S3, other basic configs) Dec 6, 2023
@cmacknz
Copy link
Member

cmacknz commented Jan 30, 2024

I read through these and they look reasonable to me. Were the configurations tested? I am holding off on approval until I can sanity check a couple of them by actually running them.

@kilfoyle
Copy link
Contributor Author

Thanks very much @cmacknz! I know these configuration examples are difficult to review. I haven't sanity tested them as I'm not always sure how, but I'm happy to try.

With @nimarezainia, I gathered the configurations by creating a policy in Fleet, adding the relevant integration, downloading the standalone config file, and then identifying the sections we thought important to include in the docs (mainly the inputs and outputs). These are meant to give users a starting point to build up an agent configuration from scratch. If there's anything I can do to help validate them let me know.

@kilfoyle
Copy link
Contributor Author

@cmacknz Just bumping this PR since now that Serverless is ungated I think it'd be good to have these examples merged into the docs. I'd need some guidance, but if I can help somehow with sanity checking please let me know.

Copy link
Contributor

@nimarezainia nimarezainia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thx David

@shainaraskas
Copy link
Contributor

Does this still need a review, or should it be closed?

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Oct 5, 2024

@shainaraskas, thanks, but no need for you to review this one, and it can stay open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integrations configuration examples for standalone Elastic Agent
4 participants