-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add standalone agent config examples (System, AWS S3, other basic configs) #744
base: main
Are you sure you want to change the base?
Conversation
I read through these and they look reasonable to me. Were the configurations tested? I am holding off on approval until I can sanity check a couple of them by actually running them. |
Thanks very much @cmacknz! I know these configuration examples are difficult to review. I haven't sanity tested them as I'm not always sure how, but I'm happy to try. With @nimarezainia, I gathered the configurations by creating a policy in Fleet, adding the relevant integration, downloading the standalone config file, and then identifying the sections we thought important to include in the docs (mainly the inputs and outputs). These are meant to give users a starting point to build up an agent configuration from scratch. If there's anything I can do to help validate them let me know. |
@cmacknz Just bumping this PR since now that Serverless is ungated I think it'd be good to have these examples merged into the docs. I'd need some guidance, but if I can help somehow with sanity checking please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thx David
Does this still need a review, or should it be closed? |
@shainaraskas, thanks, but no need for you to review this one, and it can stay open. |
As suggested in #65, we need some example configurations for standalone Elastic Agent. This adds to the ones we've already created for Nginx and Apache, via #588 and #584 respectively.
See the following preview pages for the new example configs:
NOTE:
Closes: #690
Edit: I had removed the "configure multiple outputs for each input" example, but it's now fixed up and added back in.