Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sei: ensure packages set error.kind to "pipeline_error" in on_failure processor #6582

Closed
efd6 opened this issue Jun 15, 2023 · 11 comments
Closed
Assignees

Comments

@efd6
Copy link
Contributor

efd6 commented Jun 15, 2023

SEI package style now requires that the global on_failure sets error.kind to "pipeline_error". New package generally have this behaviour, but existing packages need to be brought up to date.

Current packages (identified by CODEOWNERS) that do not do this are (package, data stream name and file):

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@MakoWish
Copy link
Contributor

@efd6,

Want me to start knocking some of these out? I won't have permissions to check boxes above, but I could refer to this issue for whichever PR's I create.

@efd6
Copy link
Contributor Author

efd6 commented Jun 19, 2023

@MakoWish You are welcome to pick up any that are important to you.

@MakoWish
Copy link
Contributor

Submit PR's for pretty much all that we use. Will see if I can get more time later to knock out a few more just to assist.

This was referenced Jul 20, 2023
@ishleenk17
Copy link
Contributor

@MakoWish : Thanks for your contributions here.

@efd6:
As I discussed with you, this change will basically help us in using error.message to store errors other than pipeline errors as well, but it requires a change in Elastic Package as well since EP uses it for pipeline errors.
Could you please share the ticket where the EP task is being tracked?

That will help us in pursuing the change done by @MakoWish to non-sei integrations.

cc: @andrewkroh

@efd6
Copy link
Contributor Author

efd6 commented Aug 14, 2023

There is no ticket for this in EP. @jsoriano Do you have any information to add here?

@jsoriano
Copy link
Member

Do you mean that elastic-package pipeline tests currently fail if they find an error.message? Probably we can make it to fail only when error.kind is pipeline_error if we are going to use this field in all packages to indicate an actual pipeline error.

If the on_failure part should be included in all packages, I wonder if it should be filled by elastic-package on build time, or by Fleet on install time.

Please open an issue with details about this use case.

@efd6
Copy link
Contributor Author

efd6 commented Aug 14, 2023

I have filed elastic/elastic-package#1392.

@jsoriano
Copy link
Member

I have filed elastic/elastic-package#1392.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants