Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mysql] Ensure event.kind is correctly set for pipeline errors #7070

Closed
wants to merge 7 commits into from

Conversation

MakoWish
Copy link
Contributor

@MakoWish MakoWish commented Jul 20, 2023

What does this PR do?

Modify mysql integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

QUESTION ON THIS ONE: The slowlog pipeline is a JSON file. Should this be converted to YAML?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  •  

How to test this PR locally

Related issues

Screenshots

@MakoWish MakoWish requested a review from a team as a code owner July 20, 2023 17:44
@elasticmachine
Copy link

elasticmachine commented Jul 20, 2023

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-13T22:17:05.019+0000

  • Duration: 28 min 17 sec

Steps errors 3

Expand to view the steps failures

Test integration: mysql
  • Took 14 min 38 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Google Storage Download
  • Took 0 min 0 sec . View more details here
Google Storage Download
  • Took 0 min 0 sec . View more details here

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Aug 13, 2023

/test

@MakoWish
Copy link
Contributor Author

This one is failing for a Grok parse failure that doesn't have anything to do with this PR. Was there a change in the CI that is catching this now and didn't catch it previously?

@botelastic
Copy link

botelastic bot commented Sep 13, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Sep 13, 2023
@botelastic
Copy link

botelastic bot commented Oct 13, 2023

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants