Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev env to current Fedimint one #46

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Conversation

elsirion
Copy link
Owner

@elsirion elsirion commented Nov 19, 2023

Thx @dpc and @maan2003 for helping me out with this one!

@elsirion elsirion force-pushed the 2023-11-update-build-env branch 2 times, most recently from 89414fa to b71f0c0 Compare November 19, 2023 21:05
@elsirion elsirion changed the title WIP: update dev env Update dev env to current Fedimint one Nov 19, 2023
@elsirion elsirion marked this pull request as ready for review November 19, 2023 21:19
@elsirion elsirion merged commit 32bed30 into master Nov 19, 2023
2 checks passed
@elsirion elsirion deleted the 2023-11-update-build-env branch November 19, 2023 21:19
@@ -17,6 +17,9 @@
{
devShells.default = pkgs.mkShell {
inputsFrom = [ fedimint.devShells."${system}".crossWasm ];
CC_wasm32_unknown_unknown = "${pkgs.llvmPackages_15.clang-unwrapped}/bin/clang-15";
Copy link

@dpc dpc Nov 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI. Flakebox has wrappers that will add toolchain envs to the shell for you:

https://github.com/fedimint/fedimint/blob/c5ce0e99cb6ee18e3e975578891e9b0f752b327e/flake.nix#L268

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that will be very useful for #47. At the time when I created this repo flakebox wasn't a thing yet and I didn't want to figure out which parts of the fedimint nix config I needed, so I just imported the whole wasm dev shell and added a few binaries. Unfortunately this seems to remove env vars. Longer term migrating to flakebox is the right thing to do imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants