Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: commit auto-generated yarn.lock #1904

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

erights
Copy link
Contributor

@erights erights commented Dec 18, 2023

closes: #XXXX
refs: #XXXX

Description

The yarn.lock changes in this PR were purely automatically generated from a clean master by running yarn. No other changes.

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

@erights erights self-assigned this Dec 18, 2023
Comment on lines +746 to +749
"@endo/env-options@^0.1.4":
version "0.1.4"
resolved "https://registry.yarnpkg.com/@endo/env-options/-/env-options-0.1.4.tgz#e516bc3864f00b154944e444fb8996a9a0c23a45"
integrity sha512-Ol8ct0aW8VK1ZaqntnUJfrYT59P6Xn36XPbHzkqQhsYkpudKDn5ILYEwGmSO/Ff+XJjv/pReNI0lhOyyrDa9mg==
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is suspicious. It suggests that something has a package.json that is pinned to a version of this package that is not in the workspace.

I would like to try this alternative and see whether package.jsons change or yarn.lock changes.

> ./scripts/get-versions.sh . | ./scripts/set-versions.sh
> yarn

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks the same after starting over from a fresh master and then running those two commands.

Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to investigate these changes more deeply.

@kriskowal
Copy link
Member

I’ve reproduced these yarn.lock changes locally and also executed the commands I recommended above and found no changes to package.json, so I am perplexed. Stay tuned.

@kriskowal
Copy link
Member

Figured it out. The problem is that Jessie.js is out of sync.

Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s land this since it at least makes sense that Jessie needs older versions. I’m separately getting Jessie in sync, which will undo these changes. endojs/Jessie#113

@erights erights merged commit 94472c4 into master Dec 19, 2023
14 checks passed
@erights erights deleted the markm-update-yarn-lock-2 branch December 19, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants