Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Specify node engine compatibility range #2020

Closed
wants to merge 2 commits into from

Conversation

kriskowal
Copy link
Member

@kriskowal kriskowal commented Jan 30, 2024

Closes #1046

The engines field is advisory, but this should ensure that folks get a warning if they’re using a version of Node.js for which SES and its libraries were not vetted. SES at least does not guarantee confinement for future versions of JavaScript, particularly in the unlikely but possible case syntax reveals more undeniable intrinsics.

This change was generated mechanically:

ls packages/*/package.json | while read -r file; do
  jq '. + { engines: {node: "^16 || ^18 || ^20" }}' $file | pbcopy
  pbpaste > $file
done

@kriskowal kriskowal force-pushed the kriskowal-engines-node-16-18-1046 branch from 4eeb964 to 203b23f Compare January 30, 2024 07:14
@kriskowal
Copy link
Member Author

I’ve removed the Node.js 12 platform compatibility test and removed it from required checks in Github CI. We can now rest easy that esm is gone (gone enough) and globalThis is broadly supported.

@kriskowal kriskowal force-pushed the kriskowal-engines-node-16-18-1046 branch 2 times, most recently from 08e6a87 to 67abfe3 Compare February 8, 2024 03:57
@mhofman
Copy link
Contributor

mhofman commented Feb 8, 2024

If we're going for specifying engines, I'd prefer to be more specific to only the LTS versions.

^16.13 || ^18.12 || ^20.9

@kriskowal kriskowal force-pushed the kriskowal-engines-node-16-18-1046 branch from 67abfe3 to eadef5b Compare February 8, 2024 21:52
@kriskowal
Copy link
Member Author

I’m closing this since the value is low and the risk of interfering with a working system is high. Also easy to revisit.

@kriskowal kriskowal closed this Apr 2, 2024
@kriskowal kriskowal deleted the kriskowal-engines-node-16-18-1046 branch April 2, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Node.js 12 support in CI
2 participants