feat(cli,daemon): Support dot-delimited petname paths for CLI eval command
#2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
force-pushed
the
rekmarks-dot-delimited-lookup
branch
from
716a073
to
42cdabc
Compare
Adds support for dot-delimited petname paths to the CLI
`eval` command. This required modifications to the `evaluate`
method of the daemon's `host.js`, and the introduction of a
new formula type, `lookup`, modeled on the `web-bundle`
formula. Also adds a unit test for this behavior.
The `lookup` formula type is necessary because the names
in a lookup path may have neither petnames nor formula
identifiers associated with them. Consider:
```text
> endo eval '10' --name ten
10
> endo eval 'foo' foo:INFO.ten.source
10
```
The only way retrieve the value for `source` is to call
`E(HOST).lookup('INFO', 'ten', 'source')`, and since the `eval`
formula expects its values to be mediated by formula identifiers,
the lookup of `INFO.ten.source` must itself be stored as
a formula.
rekmarks
force-pushed
the
rekmarks-dot-delimited-lookup
branch
from
42cdabc
to
d35bbe2
Compare
kriskowal
reviewed
Feb 6, 2024
rekmarks
force-pushed
the
rekmarks-dot-delimited-lookup
branch
from
1abcb4f
to
f0aefd8
Compare
kriskowal
reviewed
Feb 7, 2024
Comment on lines
+217
to
+230
| const petNamePath = petNamePathFrom(petNameOrPath); | ||
| if (petNamePath.length === 1) { | ||
| const formulaIdentifier = lookupFormulaIdentifierForName( | ||
| petNamePath[0], | ||
| ); | ||
| if (formulaIdentifier === undefined) { | ||
| throw new Error(`Unknown pet name ${q(petNamePath[0])}`); | ||
| } | ||
| return formulaIdentifier; | ||
| } | ||
| return formulaIdentifier; | ||
|
|
||
| const { formulaIdentifier: lookupFormulaIdentifier } = | ||
| await provideLookupFormula(petNamePath); | ||
| return lookupFormulaIdentifier; |
There was a problem hiding this comment.
Would be good to factor out a lookupFormulaIdentifierForPath function. This won’t be the last place we use it.
There was a problem hiding this comment.
We will do this later if necessary. Leaving this unresolved as a breadcrumb.
rekmarks
commented
Feb 7, 2024
Lookup formulas must be associated with the namespace for which the pet name path is valid. In practice, this means an object with a variadic `lookup()` method. Previously, these objects were referred to as "agents", but in the future, not all such object will be agents (i.e. guests or hosts). Therefore, here we replace all references to "agent" with "hub", short for "naming hub".
rekmarks
force-pushed
the
rekmarks-dot-delimited-lookup
branch
from
f0aefd8
to
e6f36a1
Compare
rekmarks
changed the title
eval CLI command
This was referenced Feb 8, 2024
kriskowal
approved these changes
Feb 8, 2024
rekmarks
changed the title
eval CLI commandeval command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2023
Description
Adds support for dot-delimited petname paths to the CLI
evalcommand. This required modifications to theevaluatemethod of the daemon'shost.js, and the introduction of a new formula type,lookup.The
lookupformula type is necessary because the names in a lookup path may have neither petnames nor formula identifiers associated with them. Consider:The only way retrieve the value for
sourceis to callE(HOST).lookup('INFO', 'ten', 'source'), and since theevalformula expects its values to be mediated by formula identifiers, the lookup ofINFO.ten.sourcemust itself be stored as a formula.The
lookupformula is an-id512formula with the following interface:The
lookupformula introduces the language of "naming hubs" into the daemon codebase. At present the only such objects are guests and hosts, which are also agents, but the category of naming hubs is expected to grow to include non-agent objects.