Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(daemon,cli): Rename terminate/kill to cancel #2073

Merged
merged 4 commits into from
Feb 14, 2024
Merged

refactor(daemon,cli): Rename terminate/kill to cancel #2073

merged 4 commits into from
Feb 14, 2024

Conversation

rekmarks
Copy link
Contributor

Renames the daemon mailbox terminate method and CLI kill command to cancel. Also renames the daemon's terminator abstraction to context.

@rekmarks rekmarks mentioned this pull request Feb 14, 2024
Closed
50 tasks
Base automatically changed from rekmarks-unique-formula-numbers to endo February 14, 2024 06:33
@rekmarks rekmarks marked this pull request as ready for review February 14, 2024 06:33
kumavis
kumavis approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@kumavis kumavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's not your word choice but context is so general I can't guess what it's use is related to. Terminator was at least closer. but yeah words

packages/daemon/src/context.js Show resolved Hide resolved
packages/daemon/src/daemon.js Outdated Show resolved Hide resolved
@rekmarks rekmarks force-pushed the rekmarks-rename-terminate-to-cancel branch from 0fd92a3 to 92dbd34 Compare February 14, 2024 19:10
@rekmarks rekmarks force-pushed the rekmarks-rename-terminate-to-cancel branch from c57edad to a29cbe8 Compare February 14, 2024 19:13
@rekmarks rekmarks merged commit dfaf39b into endo Feb 14, 2024
14 checks passed
@rekmarks rekmarks deleted the rekmarks-rename-terminate-to-cancel branch February 14, 2024 19:21
@rekmarks rekmarks mentioned this pull request Feb 14, 2024
Open
@kriskowal
Copy link
Member

Regarding the admittedly dubious name choice, context is a carrier from parent to child contexts, in particular for cancellation but also potentially other things.

And relatedly of course Abort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumavis kumavis kumavis approved these changes

@kriskowal kriskowal Awaiting requested review from kriskowal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rekmarks @kriskowal @kumavis