Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further endo daemon CLI support for dot-delimited paths #2325

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

FUDCo
Copy link
Contributor

@FUDCo FUDCo commented Jun 20, 2024

Adds support for dot-delimited petname paths in the mkdir, remove, and spawn commands, plus everywhere there's a --name option (the install, make, request, adopt, store, eval, and bundle commands).

Ref: #2023

@FUDCo FUDCo requested review from kriskowal and rekmarks June 20, 2024 08:15
@FUDCo FUDCo force-pushed the 2023-even-more-path-support branch from 0499b2d to 1f70393 Compare June 20, 2024 08:20
@FUDCo
Copy link
Contributor Author

FUDCo commented Jun 20, 2024

Something for the TODO list that came up in the doing of this PR: The switchover to allowing paths where only simple names had previously been supported forced some of the functions that accept a path in the form of a variadic argument list to be converted to take the path in the form of an array of path elements, while other functions remain using the variadic form. The resulting mixture is quite confusing. For the sake of cleanliness, consistency, and legibility (not to mention making parameter types less mysterious), all the variadic functions should be converted to the array form. The fact that this change is not completely trivial to execute highlights the need for it.

@kriskowal
Copy link
Member

I agree all methods should take the array form. Except lookup because I don’t make the rules for hub protocol (@dckc).

Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m fine with this as-is, but there’s a chance we’ll have to loosen up lookup to accept variadic pet name paths again because that’s the protocol of name hubs on the Agoric chain.

@dckc
Copy link
Contributor

dckc commented Jun 20, 2024

The rules for the lookup protocol pre-date me. @erights , @michaelfig ? thoughts?

@michaelfig
Copy link
Member

I’m fine with this as-is, but there’s a chance we’ll have to loosen up lookup to accept variadic pet name paths again because that’s the protocol of name hubs on the Agoric chain.

I don't see how that is a requirement: why would the current version of "name hubs on the Agoric chain" be relevant to the daemon's long-term API? The daemon's pet name system should work with any other name system, using adapters as necessary to be agnostic.

Add support for dot-delimited petname paths in the mkdir, remove, and
spawn commands, plus everywhere there's a --name option (the install,
make, request, adopt, store, eval, and bundle commands).
@FUDCo FUDCo force-pushed the 2023-even-more-path-support branch from 1f70393 to b6025f3 Compare June 24, 2024 21:07
@FUDCo FUDCo merged commit b7035b4 into master Jun 24, 2024
16 of 17 checks passed
@FUDCo FUDCo deleted the 2023-even-more-path-support branch June 24, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants