Skip to content

Commit

Permalink
fix(eslint): disable busted rule
Browse files Browse the repository at this point in the history
  • Loading branch information
kentcdodds committed May 24, 2024
1 parent 2a105c5 commit ffc0e53
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 25 deletions.
4 changes: 3 additions & 1 deletion configs/eslint.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ export default [
files: ['**/*.js', '**/*.jsx'],
rules: {
// most of these rules are useful for JS but not TS because TS handles these better
'import/no-unresolved': 'error',
// if it weren't for https://github.com/import-js/eslint-plugin-import/issues/2132
// we could enable this :(
// 'import/no-unresolved': 'error',
},
},

Expand Down
44 changes: 22 additions & 22 deletions configs/typescript.json
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
{
"$schema": "https://json.schemastore.org/tsconfig",
"include": ["**/*.ts", "**/*.tsx"],
"compilerOptions": {
"lib": ["DOM", "DOM.Iterable", "ES2022"],
"isolatedModules": true,
"esModuleInterop": true,
"jsx": "react-jsx",
"module": "ESNext",
"target": "ES2022",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"strict": true,
"noImplicitAny": true,
"allowJs": true,
"forceConsistentCasingInFileNames": true,
"paths": {
"#/*": ["./*"]
},
"skipLibCheck": true,
"allowImportingTsExtensions": true,
"noEmit": true
}
"$schema": "https://json.schemastore.org/tsconfig",
"include": ["**/*.ts", "**/*.tsx"],
"compilerOptions": {
"lib": ["DOM", "DOM.Iterable", "ES2022"],
"isolatedModules": true,
"esModuleInterop": true,
"jsx": "react-jsx",
"module": "ESNext",
"target": "ES2022",
"moduleResolution": "bundler",
"resolveJsonModule": true,
"strict": true,
"noImplicitAny": true,
"allowJs": true,
"forceConsistentCasingInFileNames": true,
"paths": {
"#/*": ["./*"]
},
"skipLibCheck": true,
"allowImportingTsExtensions": true,
"noEmit": true
}
}
4 changes: 2 additions & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"extends": "./configs/typescript.json",
"include": ["**/*.ts", "**/*.tsx", "**/*.js", "**/*.jsx"]
"extends": "./configs/typescript.json",
"include": ["**/*.ts", "**/*.tsx", "**/*.js", "**/*.jsx"]
}

0 comments on commit ffc0e53

Please sign in to comment.