Add tsconfigRootDir definition to eslint config #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortc
force-pushed
the
tsconfig-root-dir
branch
2 times, most recently
from
d184906
to
5790f98
Compare
…oper filepaths to eslint LSP
shortc
force-pushed
the
tsconfig-root-dir
branch
from
5790f98
to
53a4e4b
Compare
kentcdodds
requested changes
Nov 7, 2024
| @@ -132,6 +132,7 @@ export const config = [ | |||
| parser: (await import('typescript-eslint')).parser, | |||
| parserOptions: { | |||
| projectService: true, | |||
| tsconfigRootDir: import.meta.dirname, | |||
There was a problem hiding this comment.
Wouldn't this resolve to ./node_modules/@epic-web/config? I don't think that's where we want to configure this root dir to 🤔
There was a problem hiding this comment.
Ahh okay, I was thinking it would behave differently and resolve to the directory of my eslint.config.js since the epicweb config is spread into our flat eslint config.
After testing and editing the project's epicweb config node module eslint config file, the vscode-eslint LSP used in Helix is still happy when given /Users/[username]/[[path_to_project]/[project]/node_modules/@epic-web/config as the tsconfigDir value for some reason.
Anyways, I'll go ahead and close this PR. Sorry for wasting your time!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my current project I am using the epicweb eslint configuration. My main editor of choice is Helix and without tsconfigRootDir defined the following error is thrown by the vscode-eslint LSP for every tsx file that I open:
Parsing error: [/complete/filepath/index.tsx] was not found by the project service. Consider either including it in the tsconfig.json or including it in allowDefaultProjectHere is the typescript-eslint doc page that I pulled this from: https://typescript-eslint.io/getting-started/typed-linting/