Ensure Number("1A")==NaN, previously we just parsed the digits we cou…

…ld (fix #2555)

ChangeLog

@@ -16,6 +16,7 @@
             STM32: Stay away when USB is connected, even if no app is reading
             Remove Ctrl-A/D/E/U/W code handling to free up flash space (the IDE/or VT100 terminals all use escape codes)
             Ensure that 1%0.0===NaN (fix #2556)
+            Ensure Number("1A")==NaN, previously we just parsed the digits we could (fix #2555)
 
      2v24 : Bangle.js2: Add 'Bangle.touchRd()', 'Bangle.touchWr()'
             Bangle.js2: After Bangle.showTestScreen, put Bangle.js into a hard off state (not soft off)

src/jsvar.c

@@ -2249,7 +2249,9 @@ JsVarFloat jsvGetFloat(const JsVar *v) {
       if (buf[0]==0) return 0; // empty string -> 0
       if (!strcmp(buf,"Infinity")) return INFINITY;
       if (!strcmp(buf,"-Infinity")) return -INFINITY;
-      return stringToFloat(buf);
+      const char *endOfNumber = 0;
+      JsVarFloat v = stringToFloatWithRadix(buf,0,&endOfNumber);
+      if (*endOfNumber==0) return v; // only return the value if there wasn't something after it in the string
     }
   }
   return NAN;
@@ -2272,7 +2274,7 @@ JsVar *jsvAsNumber(JsVar *var) {
     if (jsvGetString(var, buf, sizeof(buf))==sizeof(buf)) {
       jsExceptionHere(JSET_ERROR, "String too big to convert to number");
       return jsvNewFromFloat(NAN);
-    } else
+    } else // jsvIsStringNumericInt=true so we're sure this'll be successful
       return jsvNewFromLongInteger(stringToInt(buf));
   }
   // Else just try and get a float