Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge Morpho tokens #973

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Bridge Morpho tokens #973

merged 7 commits into from
Nov 7, 2024

Conversation

Jean-Grimal
Copy link
Contributor

@Jean-Grimal Jean-Grimal requested review from wbnns and a team as code owners October 28, 2024 15:38
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jean-Grimal

Thanks! There is a syntax error in the metadata; it should match the format of the data file in the README:
https://github.com/morpho-org/ethereum-optimism.github.io.git

In this case, on L7 sepolia should be address and ethereum on L6 should be sepolia.

Could you please update?

@Jean-Grimal
Copy link
Contributor Author

@Jean-Grimal

Thanks! There is a syntax error in the metadata; it should match the format of the data file in the README: https://github.com/morpho-org/ethereum-optimism.github.io.git

In this case, on L7 sepolia should be address and ethereum on L6 should be sepolia.

Could you please update?

Indeed, thanks

It's fixed.

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbnns
Copy link
Member

wbnns commented Nov 7, 2024

@Jean-Grimal

Heya, thanks for updating -- looks like this is still failing CI/CD.

2024-11-07 at 22 58 09@2x

if you'd like this to be bridgeable you'd need to leverage the factory contract for the deployment on Base and Base Sepolia:

Details here:
https://docs.base.org/docs/tokens/list

Relevant section:
2024-11-07 at 23 01 17@2x

Hope that helps! If you have any questions, just let us know. 👍

@Jean-Grimal Jean-Grimal changed the title Add Morpho on seplolia and base-sepolia networks Bridge Morpho tokens Nov 7, 2024
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@Jean-Grimal Thanks for building on Base 🔵

Copy link
Contributor

mergify bot commented Nov 7, 2024

Merge failed. Please see automated check logs for more details.

@wbnns wbnns merged commit aa089f3 into ethereum-optimism:master Nov 7, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants