Adding BICO token on Base #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbnns
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Hi there! Thanks for the PR! CI/CD is currently failing due to the following issue:
error: BICO on chain ethereum token 0xf17e65822b568b3903685a7c9f496cf7656cc6c2 has incorrect name. Got Biconomy Token
In order to fix you'll need to add an override to the metadata as described here:
https://github.com/ethereum-optimism/ethereum-optimism.github.io?tab=readme-ov-file#per-token-overrides
If you have any questions or need further assistance please let us know.
|
Added the Token name overrides for ethereum |
wbnns
approved these changes
Nov 9, 2024
There was a problem hiding this comment.
ACK
@tomarsachin2271 Thanks for the updates and for building on Base 🔵
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding BICO token on Base.
Tests
Additional context
Deployed BICO token on Base and now adding it to superchain token list.
Metadata