Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update (masked) standard bytecode hash for mips @ op-contracts/v1.6.0 #688

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

geoknee
Copy link
Collaborator

@geoknee geoknee commented Nov 18, 2024

I believe we have the incorrect bytecode hash stored in the standard TOML file for the MIPS contract at the latest governance approved release. This PR updates it to the correct value and gets just validate 10 passing again.

To reproduce this:

  1. I checked out op-contracts/v1.6.0 in the monorepo
  2. forge build
  3. Grab immutableReferences field from forge-artifacts/MIPS.sol/MIPS.json and update standard-immutables.toml (no semantically meaningful change here actually)
  4. cast code 0x16e83cE5Ce29BF90AD9Da06D2fE6a15d5f344ce4 and verify (using https://difff.jp/en/) returned bytecode matches the deployedBytecode from the above MIPS.json file, with the immutables filled in with the PreimageOracle address.
  5. Updatestandard-bytecodes.toml with the hash reported by the just validate 10 command.

@geoknee geoknee requested a review from a team as a code owner November 18, 2024 10:13
@geoknee geoknee added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 3c64766 Nov 18, 2024
11 checks passed
@geoknee geoknee deleted the gk/mips-bytecode-hash-fix branch November 18, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants