Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jose): updated to use a new jose library #23

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented May 31, 2024

Description of change

We use this library in our project, it has more features and enables more signatures.

Type of change

Please delete options that are not relevant.

  • Refactoring

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • All Tests of the framework still pass.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the readme
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This commit updates the code base to use this jose library instead.
@goncalo-frade-iohk goncalo-frade-iohk requested a review from a team as a code owner May 31, 2024 16:08
@goncalo-frade-iohk goncalo-frade-iohk deleted the refactor/update-jose-library branch May 31, 2024 16:09
@goncalo-frade-iohk goncalo-frade-iohk restored the refactor/update-jose-library branch May 31, 2024 16:10
@goncalo-frade-iohk goncalo-frade-iohk deleted the refactor/update-jose-library branch May 31, 2024 16:11
@dtsiflit
Copy link
Collaborator

dtsiflit commented Jun 4, 2024

Great work @goncalo-frade-iohk! Would you consider re-opening this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants