Skip to content

Commit

Permalink
Docker CI GHA: improve secret management
Browse files Browse the repository at this point in the history
  • Loading branch information
hbenali committed Oct 17, 2023
1 parent 5445dea commit 4770e9e
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ jobs:
dockerImage: "exoplatform/ci"
dockerImageTag: ${{ matrix.imageTag }}
dockerFileContext: ${{ matrix.context }}
dockerHubUsername: ${{ secrets.DOCKER_USERNAME }}
dockerHubPassword: ${{ secrets.DOCKER_PASSWORD }}
secrets:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}

build-jdk-images:
name: "Build JDK Images"
Expand All @@ -49,8 +50,9 @@ jobs:
dockerImage: "exoplatform/ci"
dockerImageTag: ${{ matrix.imageTag }}
dockerFileContext: ${{ matrix.context }}
dockerHubUsername: ${{ secrets.DOCKER_USERNAME }}
dockerHubPassword: ${{ secrets.DOCKER_PASSWORD }}
secrets:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}

build-maven-images:
name: "Build Maven Images"
Expand Down Expand Up @@ -88,5 +90,6 @@ jobs:
dockerImage: "exoplatform/ci"
dockerImageTag: ${{ matrix.imageTag }}
dockerFileContext: ${{ matrix.context }}
dockerHubUsername: ${{ secrets.DOCKER_USERNAME }}
dockerHubPassword: ${{ secrets.DOCKER_PASSWORD }}
secrets:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}

0 comments on commit 4770e9e

Please sign in to comment.