Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Configure the PortalNavigationIconUpgradePlugin to set icons to the portal navigation nodes - EXO-69848 #210

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

sofyenne
Copy link
Member

@sofyenne sofyenne commented Mar 7, 2024

Prior to this change after migrating from the 6.4 to the 6.5 then to the 6.6 version , the external stream node navigation icon was incorrect , this change is going to configure the PortalNavigationIconUpgradePlugin in order to set icons for the portal navigation nodes .

@azayati azayati changed the title fix: Configure the PortalNavigationIconUpgradePlugin to set icons to the portal navigation nodes - EXO-69848 (#209) fix: Configure the PortalNavigationIconUpgradePlugin to set icons to the portal navigation nodes - EXO-69848 Mar 7, 2024
Copy link
Member

@azayati azayati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sofyenne have you tested that on pgsql ?

…the portal navigation nodes - EXO-69848 (#209)

Prior to this change after migrating from the 6.4 to the 6.5 then to the 6.6 version , the external stream node navigation icon was incorrect , this change is going to configure the PortalNavigationIconUpgradePlugin in order to set icons for the portal navigation nodes .
@sofyenne
Copy link
Member Author

sofyenne commented Mar 8, 2024

@sofyenne have you tested that on pgsql ?

Yep!

@@ -0,0 +1,103 @@
package org.exoplatform.migration;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put the header

@sofyenne sofyenne requested a review from azayati March 8, 2024 14:36
Copy link
Member

@azayati azayati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sofyenne sofyenne enabled auto-merge (squash) March 8, 2024 14:41
Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Blocker Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sofyenne sofyenne merged commit 7390803 into develop Mar 8, 2024
6 of 7 checks passed
@sofyenne sofyenne deleted the merge-69848 branch March 8, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants