Move CI to GHA; update supported Ruby, ddtrace, Redis versions [DEM-331] #72
Conversation
kraila
force-pushed
the
kr/gha-ci
branch
2 times, most recently
from
5260b41
to
0ae0d14
Compare
kraila
force-pushed
the
kr/gha-ci
branch
5 times, most recently
from
f4b4219
to
fd38f2e
Compare
kraila
changed the title
kraila
changed the title
.github/workflows/ci.yml
Outdated
| postgres: [ '12', '13', '14', '15', '16' ] | ||
| redis: [ '6', '7' ] |
There was a problem hiding this comment.
Curious if you think we need to test all the PG and Redis versions. I don't think we were before. Are we using anything beyond normal PG queries or Redis commands? Either way I think we can probably drop PG 12 and 13 at least, since the monolith along with other projects being on 14 now.
There was a problem hiding this comment.
Tbh this is almost certainly overkill; I was on a bit of a "Test All The Things" spree yesterday, given how many weird version issues we ran into with moving this project to GHA in the first place, but you make a good point re: redis and postgres queries
There was a problem hiding this comment.
I think I will tell the CI workflow to use latest of each and that way we'll see on any new PR if something breaks when one of the images gets updates
kraila
changed the title
CHANGELOG.md
Outdated
| @@ -1,6 +1,10 @@ | |||
| # sidekiq_publisher | |||
|
|
|||
| ## (Unreleased) | |||
| ## (unreleased; 3.0.0) | |||
There was a problem hiding this comment.
Do we have to change this after we push out the actual release? Just curious why we're labeling this as "unreleased"?
There was a problem hiding this comment.
I was planning to one final update to this PR to remove that -- good question
There was a problem hiding this comment.
I may as well do that now!
What did we change?
2.6and2.7as they are past end of lifeddtrace <= 1.8.05.xWhy are we doing this?
Moving to Github workflows for CI unearthed a number of incompatibilities across versions of ruby, ddtrace, and redis. As some of these were past EOL, we (Demand Scalability team) decided to drop support for them and prepare to release a new gem version as well.
I've also added testing through Redis 7 and Postgres 16, as this did not need any additional changes and ensures the gem will be tested against the most recent versions of both.
How was it tested?