[RLSH-503] Add support for ActiveSupport 7.1, drop support for Sidekiq < 6.4.1 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gguerini
changed the title
tristandunn
reviewed
Feb 13, 2024
gguerini
changed the title
gguerini
force-pushed
the
gg-add-support-for-activesupport-7.1-drop-sidekiq-below-6.4.1
branch
from
450fcf8
to
12d8cc7
Compare
gguerini
changed the title
tristandunn
approved these changes
Feb 13, 2024
ransombriggs
approved these changes
Feb 13, 2024
gguerini
force-pushed
the
gg-add-support-for-activesupport-7.1-drop-sidekiq-below-6.4.1
branch
from
12d8cc7
to
92d346e
Compare
gguerini
deleted the
gg-add-support-for-activesupport-7.1-drop-sidekiq-below-6.4.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did we change?
ActiveSupportandActiveJob7.1.Sidekiq< 6.4.1.appraisalsto support the current versions ofActiveSupportandSidekiq.5.0.0Why are we doing this?
This is the outcome of a conversation that can be found here.
How was it tested?