feat: return job ID from client push #78
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did we change?
Have
SidekiqPublisher::Worker.client_push
return a job ID string, which matches the sidekiq gem behavior. Currently.client_push
returns the insertedSidekiqPublisher::Job
ActiveRecord instance.Why are we doing this?
Having a consistent return value between the native sidekiq gem and the sidekiq_publisher gem makes things easier to handle. Otherwise clients have to juggle using
#job_id
method (for sidekiq_publisher gem) or the job ID string (for sidekiq gem). For example:How was it tested?