Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unneeded json-schema.org JSON files #6588

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: remove unneeded json-schema.org JSON files #6588

merged 1 commit into from
Nov 14, 2024

Conversation

manusa
Copy link
Member

@manusa manusa commented Nov 14, 2024 •
edited
Loading

Description

Fixes #6222

  • Removed kube-schema.json files
  • Removed validation-schema.json files
  • Removed duplicate manifest.vm files

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa
fix: remove unneeded json-schema.org JSON files
cfeee83 
- Removed kube-schema.json files
- Removed validation-schema.json files

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa added this to the 7.0.0 milestone Nov 14, 2024 — with automated-tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@manusa manusa merged commit cd62ff1 into fabric8io:main Nov 14, 2024
19 of 20 checks passed
@manusa manusa deleted the fix/remove-unneeded-jsonschema-files branch November 14, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd Awaiting requested review from oscerd oscerd is a code owner

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia rohanKanojia is a code owner

@shawkins shawkins Awaiting requested review from shawkins shawkins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Remove .json files (kube-schema.json, validation-schema.json, $$$extension.json)
1 participant
@manusa