Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(crd-generator): Change format in @PrinterColum to enum #6620

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat(crd-generator): Change format in @PrinterColum to enum #6620

wants to merge 6 commits into from
+85 −38

Conversation

baloo42
Copy link
Contributor

@baloo42 baloo42 commented Nov 18, 2024

Description

Fixes: #6455

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
58.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaTP andreaTP Awaiting requested review from andreaTP andreaTP will be requested when the pull request is marked ready for review andreaTP is a code owner

@metacosm metacosm Awaiting requested review from metacosm metacosm will be requested when the pull request is marked ready for review metacosm is a code owner

@manusa manusa Awaiting requested review from manusa manusa will be requested when the pull request is marked ready for review manusa is a code owner

@oscerd oscerd Awaiting requested review from oscerd oscerd will be requested when the pull request is marked ready for review oscerd is a code owner

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia rohanKanojia will be requested when the pull request is marked ready for review rohanKanojia is a code owner

@shawkins shawkins Awaiting requested review from shawkins shawkins will be requested when the pull request is marked ready for review shawkins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CRD-Generator: Change format in @PrinterColum to enum
1 participant
@baloo42