Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correções - Release 2 #50

Merged
merged 13 commits into from
Dec 14, 2023
Merged

Correções - Release 2 #50

merged 13 commits into from
Dec 14, 2023

Conversation

lipeaaraujo
Copy link
Collaborator

Motivação

Correção de bugs e erros de funcionalidade encontrados nas páginas da release 2, e necessidade de aumento na cobertura de testes.

Mudanças

  • Implementação correta da edição de padrão
  • Correção da estilização dos forms de padrão
  • Correção de bug no redirecionamento da página de login
  • Correção de erros visuais nas páginas de forma geral
  • Correção da estilização dos forms de impressora

Status Checklist

  • Test
  • Lint
  • Development

Screenshots

Before After

Execução

  • Acesse a página url /Home

lipeaaraujo and others added 13 commits December 11, 2023 12:07
Co-authored-by: LipeAKugel <felipearaujodff@gmail.com>
Co-authored-by: vitordiniz25 <vitordiniz25@gmail.com>
Co-authored-by: LipeAKugel <felipearaujodff@gmail.com>
Co-authored-by: vitordiniz25 <vitordiniz25@gmail.com>
Co-authored-by: LipeAKugel <felipearaujodff@gmail.com>
Co-authored-by: vitordiniz25 <vitordiniz25@gmail.com>
Co-authored-by: LipeAKugel <felipearaujodff@gmail.com>
Co-authored-by: vitordiniz25 <vitordiniz25@gmail.com>
Co-authored-by: LipeAKugel <felipearaujodff@gmail.com>
Co-authored-by: vitordiniz25 <vitordiniz25@gmail.com>
Co-authored-by: LipeAKugel <felipearaujodff@gmail.com>
Co-authored-by: vitordiniz25 <vitordiniz25@gmail.com>
Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
2023-2-print-go ✅ Ready (Inspect) Visit Preview Dec 14, 2023 4:01pm

Copy link

sonarcloud bot commented Dec 14, 2023

@vitordiniz25 vitordiniz25 self-requested a review December 14, 2023 16:04
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (57d16ff) 85.85% compared to head (3636926) 89.76%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/components/forms/EditPatternForm.js 81.25% 3 Missing ⚠️
src/api/api.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   85.85%   89.76%   +3.91%     
==========================================
  Files          51       51              
  Lines         919      938      +19     
  Branches      224      227       +3     
==========================================
+ Hits          789      842      +53     
+ Misses        118       89      -29     
+ Partials       12        7       -5     
Flag Coverage Δ
jest 89.76% <87.50%> (+3.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@vitordiniz25 vitordiniz25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AntonioRangelC AntonioRangelC requested review from julisous, yuriAlves5 and mibasFerraz and removed request for mibasFerraz and julisous December 14, 2023 17:18
Copy link
Collaborator

@julisous julisous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprovado

@lipeaaraujo lipeaaraujo merged commit 8ad9fb9 into main Dec 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants