Hash ticket before performing arithmetic #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure no arithmetic properties leak from BLS-G2 affine compressed representation. Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Kubuxu
force-pushed
the
feat/harden-ticket-arit
branch
from
49fe9e2
to
c72178b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
+ Coverage 74.15% 74.45% +0.29%
==========================================
Files 39 39
Lines 3753 3754 +1
==========================================
+ Hits 2783 2795 +12
+ Misses 691 684 -7
+ Partials 279 275 -4
|
masih
approved these changes
Jul 7, 2024
|
@Kubuxu could you please submit a PR to the FIP specifying this? |
|
The way of going from ticket to ordering is not specified in the FIP, which is why I didn't submit it initially. I can submit it, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure no arithmetic properties leak from BLS-G2 affine compressed
representation.