-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor validation logic into a mutex-free pluggable struct #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
force-pushed
the
masih/validation-refactor
branch
2 times, most recently
from
September 23, 2024 12:14
c49ae37
to
b387cf7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
==========================================
- Coverage 76.90% 76.72% -0.18%
==========================================
Files 64 65 +1
Lines 5451 5487 +36
==========================================
+ Hits 4192 4210 +18
- Misses 857 872 +15
- Partials 402 405 +3
|
Stebalien
reviewed
Sep 23, 2024
masih
force-pushed
the
masih/validation-refactor
branch
from
September 23, 2024 13:10
b387cf7
to
52e06c4
Compare
Stebalien
reviewed
Sep 23, 2024
masih
force-pushed
the
masih/validation-refactor
branch
2 times, most recently
from
September 23, 2024 15:16
380fc6c
to
5c00dc0
Compare
Stebalien
reviewed
Sep 23, 2024
masih
force-pushed
the
masih/validation-refactor
branch
from
September 23, 2024 15:47
5c00dc0
to
13cb79b
Compare
Refactor the validation logic out of `Participant` and into its own dedicated struct that is mutex-free and listens to the progress made by the participant to infer the correct validation path. The change above significantly reduces the need for mutex control over current instance, which makes it easier to plug in extra conditional behaviour, e.g. #583. Fixes #561
masih
force-pushed
the
masih/validation-refactor
branch
from
September 23, 2024 15:49
13cb79b
to
9fad427
Compare
Stebalien
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the validation logic out of
Participant
and into its own dedicated struct that is mutex-free and listens to the progress made by the participant to infer the correct validation path.The change above significantly reduces the need for mutex control over current instance, which makes it easier to plug in extra conditional behaviour, e.g. #583.
Fixes #561