Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an off-by-one in the powerstore #736

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

Stebalien
Copy link
Member

Also fix the test.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.95%. Comparing base (12514c1) to head (cfc5564).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
- Coverage   75.18%   74.95%   -0.23%     
==========================================
  Files          70       70              
  Lines        6938     6939       +1     
==========================================
- Hits         5216     5201      -15     
- Misses       1311     1324      +13     
- Partials      411      414       +3     
Files with missing lines Coverage Δ
internal/powerstore/powerstore.go 61.86% <100.00%> (ø)

... and 4 files with indirect coverage changes

@masih masih added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 6e3e139 Nov 6, 2024
13 checks passed
@masih masih deleted the steb/fix-base-pt-off-by-one branch November 6, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants