fix: fix F3 JSON RPC error pass through across API boundary #12637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
added
release/backport
skip/changelog
masih
force-pushed
the
masih/f3-json-rpc-err-passthrough
branch
from
8361906
to
0a576c4
Compare
Fix the issue by instantiating pointers to sentinel F3 error values and assert that errors indeed pass through via an integration test. Fixes #12630
masih
force-pushed
the
masih/f3-json-rpc-err-passthrough
branch
from
0a576c4
to
d7d37d0
Compare
21 tasks
Stebalien
approved these changes
Oct 24, 2024
rjan90
pushed a commit
that referenced
this pull request
Oct 28, 2024
Fix the issue by instantiating pointers to sentinel F3 error values and assert that errors indeed pass through via an integration test. Fixes #12630
rjan90
pushed a commit
that referenced
this pull request
Oct 28, 2024
Fix the issue by instantiating pointers to sentinel F3 error values and assert that errors indeed pass through via an integration test. Fixes #12630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Fix the issue by instantiating pointers to sentinel F3 error values and assert that errors indeed pass through via an integration test.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: