test(eth): fix execution/inclusion off-by-one #12642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StateSearchMsg returns the tipset in which the message was executed to make it easier to get receipts, the state root, etc. But the ETH API cares about the inclusion tipset.
Stebalien
added
the
skip/changelog
|
All aboard the flake train: #12643. That is, ignore the test failure, it's unrelated. |
8 tasks
masih
approved these changes
Oct 26, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#12618
Proposed Changes
Fix execution/inclusion off-by-one in the eth conformance tests.
StateSearchMsg returns the tipset in which the message was executed to make it easier to get receipts, the state root, etc. But the ETH API cares about the inclusion tipset.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: