Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog] fix(cli): print RebroadcastBackoffExponent in lotus f3 manifest #12647

Merged

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Oct 28, 2024

Related Issues

(Came across this while implementing ChainSafe/forest#4937)
RebroadcastBackoffExponent seems to be dropped in lotus f3 manifest output.

Proposed Changes

Print GPBFT Rebroadcast Backoff Exponent: 1.3 line in lotus f3 manifest output

Additional Info

Output with the change

➜  lotus git:(master) ✗ ./lotus f3 manifest
Manifest:
  Protocol Version:     4
  Paused:               false
  Initial Instance:     0
  Initial Power Table:  bafy2bzaceab236vmmb3n4q4tkvua2n4dphcbzzxerxuey3mot4g3cov5j3r2c
  Bootstrap Epoch:      2081674
  Network Name:         calibrationnet
  Ignore EC Power:      false
  Committee Lookback:   10
  Catch Up Alignment:   15s

  GPBFT Delta:                        6s
  GPBFT Delta BackOff Exponent:       2
  GPBFT Max Lookahead Rounds:         5
  GPBFT Rebroadcast Backoff Base:     6s
  GPBFT Rebroadcast Backoff Exponent: 1.3
  GPBFT Rebroadcast Backoff Spread:   0.1
  GPBFT Rebroadcast Backoff Max:      1m0s

  EC Period:            30s
  EC Finality:          900
  EC Delay Multiplier:  2
  EC Head Lookback:     0
  EC Finalize:          true

  Certificate Exchange Client Timeout:    10s
  Certificate Exchange Server Timeout:    1m0s
  Certificate Exchange Min Poll Interval: 30s
  Certificate Exchange Max Poll Interval: 2m0s

Checklist

Before you mark the PR ready for review, please make sure that:

@hanabi1224 hanabi1224 changed the title fix(cli): print RebroadcastBackoffExponent in lotus f3 manifest [skip changelog]fix: cli: print RebroadcastBackoffExponent in lotus f3 manifest Oct 28, 2024
@hanabi1224 hanabi1224 changed the title [skip changelog]fix: cli: print RebroadcastBackoffExponent in lotus f3 manifest [skip changelog]fix(cli): print RebroadcastBackoffExponent in lotus f3 manifest Oct 28, 2024
@hanabi1224 hanabi1224 changed the title [skip changelog]fix(cli): print RebroadcastBackoffExponent in lotus f3 manifest [skip changelog] fix(cli): print RebroadcastBackoffExponent in lotus f3 manifest Oct 28, 2024
@hanabi1224 hanabi1224 marked this pull request as ready for review October 28, 2024 09:23
@Kubuxu Kubuxu merged commit c402b5b into filecoin-project:master Oct 28, 2024
91 of 92 checks passed
Kubuxu pushed a commit that referenced this pull request Oct 28, 2024
@hanabi1224 hanabi1224 deleted the hm/RebroadcastBackoffExponent branch October 28, 2024 18:27
rjan90 pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants