Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(f3): try to make f3 participation stick to a single node #12664

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Nov 1, 2024

Related Issues

Proposed Changes

Try to make f3 participation stick to a single node. Because apparently this is a feature none of us knew about.

Checklist

Before you mark the PR ready for review, please make sure that:

@Stebalien
Copy link
Member Author

Requires #12665 to actually work in practice. That PR also has a test (not for F3, but a test that ensures that this feature works correctly).

@Stebalien Stebalien requested a review from masih November 1, 2024 04:02
@Stebalien Stebalien enabled auto-merge (squash) November 1, 2024 04:02
@Stebalien
Copy link
Member Author

Note: this will try to stick to a single node, but it'll gracefully move on to a new node the first time a request against the current one fails.

@Stebalien Stebalien requested a review from Kubuxu November 1, 2024 04:12
@masih
Copy link
Member

masih commented Nov 1, 2024

But participation should work without this feature. Right? What does this give us that we need / don't have in the current participation mechanism?

@Stebalien
Copy link
Member Author

Hm. I guess it'll just make it slightly more efficient? It's not actually critical.

The built-in multi-node dispatch currently works by trying all nodes in-order till once succeeds. So, e.g., node 1 returns an error when requesting a ticket, we'll get the ticket from node 2. Then we'll try to participate with node 1 (and fail), switching to node 2 (and succeeding). Every subsequent request will take two requests due to the overlapping leases.

With this change, we'll permanently switch to node 2 until node 2 returns an error. At that point, we'll walk through the available nodes until one doesn't return an error or until we've tried 5 nodes.

@Stebalien Stebalien merged commit 2da0b72 into master Nov 1, 2024
83 checks passed
@Stebalien Stebalien deleted the steb/fix-single-node branch November 1, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants