Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): switch to the stdlib atomic package in snapshot code #12666

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Nov 1, 2024

Related Issues

We're using uber's atomic instead of the builtin one in our snapshot logic. We probably used uber's by mistake. It comes into our dependency tree via go-ipld-blockstore and will leave via filecoin-project/filecoin-ffi#497.

Proposed Changes

Switch to the builtin atomic package.

Checklist

Before you mark the PR ready for review, please make sure that:

We probably used uber's by mistake. It comes into our dependency tree
via go-ipld-blockstore and will leave via
filecoin-project/filecoin-ffi#497.
@Stebalien Stebalien added the skip/changelog This change does not require CHANGELOG.md update label Nov 1, 2024
@Stebalien Stebalien requested a review from rvagg November 1, 2024 04:13
@masih masih merged commit ffe5b28 into master Nov 12, 2024
85 of 86 checks passed
@masih masih deleted the steb/fix-atomic branch November 12, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

4 participants