fix(f3): when returning a partially used lease, trim its ValidityTerm #12667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Kubuxu
added
skip/changelog
Stebalien
approved these changes
Nov 1, 2024
|
Oh, I see. The lease will eventually expire. We just won't get the overlap behavior. |
masih
reviewed
Nov 1, 2024
| @@ -104,6 +104,8 @@ func (l *leaser) participate(ticket api.F3ParticipationTicket) (api.F3Participat | |||
| if found { | |||
| // short-circuite for reparticipation. | |||
| if currentLease == newLease { | |||
| newLease.ValidityTerm = newLease.ToInstance() - instant.ID | |||
| newLease.FromInstance = instant.ID | |||
There was a problem hiding this comment.
New lease is not stored in lease map. Should it be?
There was a problem hiding this comment.
It shouldn't be stored because the lease in the lease map is the decoded ticket. It's... confusing and we should probably do something about it.
Kubuxu
added a commit
to Kubuxu/curio
that referenced
this pull request
Nov 1, 2024
lotus-rc2 miss-registered error types, rc3 does it correctly Next release will additionally contain fix for early reneweal. filecoin-project/lotus#12667 filecoin-project#312 is still an issue Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Kubuxu
added a commit
to Kubuxu/curio
that referenced
this pull request
Nov 1, 2024
lotus-rc2 miss-registered error types, rc3 does it correctly Next release will additionally contain fix for early reneweal. filecoin-project/lotus#12667 filecoin-project#312 is still an issue Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
18 tasks
magik6k
pushed a commit
to filecoin-project/curio
that referenced
this pull request
Nov 2, 2024
lotus-rc2 miss-registered error types, rc3 does it correctly Next release will additionally contain fix for early reneweal. filecoin-project/lotus#12667 #312 is still an issue Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
rjan90
pushed a commit
that referenced
this pull request
Nov 4, 2024
…#12667) Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
rjan90
pushed a commit
that referenced
this pull request
Nov 6, 2024
…#12667) Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the early renew logic will never trigger.