Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong nested field setting #96

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix: wrong nested field setting #96

merged 1 commit into from
Oct 22, 2024

Conversation

yashmehrotra
Copy link
Member

@yashmehrotra yashmehrotra commented Oct 22, 2024 •
edited
Loading 

$ kubectl log deploy/canary-checker -n mission-control | rg 'unknown field "creationTimestamp"' | wc -l
55

This was being set previously

{
  "apiVersion": "source.toolkit.fluxcd.io/v1",
  "creationTimestamp": {
    "nil": "metadata"
  },
  "kind": "HelmRepository",

@yashmehrotra yashmehrotra force-pushed the warning-fix branch 2 times, most recently from c5d2cc7 to 1588648 Compare October 22, 2024 03:27
@moshloop moshloop merged commit 7817bb3 into master Oct 22, 2024
6 checks passed
@moshloop moshloop deleted the warning-fix branch October 22, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshloop moshloop Awaiting requested review from moshloop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashmehrotra @moshloop