Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[wip] Move db logic to stdlib #147

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[wip] Move db logic to stdlib #147

wants to merge 5 commits into from

Conversation

wild-endeavor
Copy link
Contributor

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #147 (f234638) into master (0dbe3c2) will decrease coverage by 1.02%.
The diff coverage is 31.25%.

❗ Current head f234638 differs from pull request most recent head 90331d1. Consider uploading reports for the commit 90331d1 to get more accurate results

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   68.16%   67.15%   -1.02%     
==========================================
  Files          69       71       +2     
  Lines        4081     4189     +108     
==========================================
+ Hits         2782     2813      +31     
- Misses       1141     1216      +75     
- Partials      158      160       +2     
Flag Coverage Δ
unittests 67.15% <31.25%> (-1.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/config.go 93.93% <0.00%> (-6.07%) ⬇️
database/mysql.go 27.08% <27.08%> (ø)
database/postgres.go 35.48% <35.48%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

wild-endeavor and others added 4 commits December 5, 2022 15:34
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants