Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtRepOfObj for IsLetterAssocWordRep: return mutable list #5805

Merged
merged 1 commit into from
Sep 29, 2024
Merged

ExtRepOfObj for IsLetterAssocWordRep: return mutable list #5805

merged 1 commit into from
Sep 29, 2024

Commits on Sep 26, 2024

  1. ExtRepOfObj for IsLetterAssocWordRep: return mutable list 

    ... as this is how GAP behaved for years, and also many (most?)
other `ExtRepOfObj` implementations also return a mutable list.
So it seems plausible to mimic that.

At the same time, keep the return value of `ERepLettWord` immutable,
to avoid many needless copies of a list in code that does things
like `Length(ERepLettWord(w))` or `ERepLettWord(w)[2*n-1]`.
    @fingolfin
    fingolfin committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    67e2326 View commit details
    Browse the repository at this point in the history