Cleanup tests #27
Merged
Cleanup tests #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: Currently we are just appending "json.schemas" key into the object
Merged
shoshta73
force-pushed
the
tests/improvements
branch
2 times, most recently
from
450d74a
to
d25d487
Compare
shoshta73
force-pushed
the
tests/improvements
branch
from
d25d487
to
e03008e
Compare
|
I should note.. my local venv failed. VSCode tried to show me what to do about this. I havent set up python tooling in Vi/Vim yet.. I'm slow right now. |
gbowne1
approved these changes
Oct 13, 2024
Merged
|
Still testing and reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26,
I am strongly reccomending to delay merging this PR until #22 is not resolved so we can frist move patch file 0001 to the source instead of keeping it in /patches directory